Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arithmetic Private Methods Changed to Public #7207

Open
wants to merge 2 commits into
base: dev/patch
Choose a base branch
from
Open

Arithmetic Private Methods Changed to Public #7207

wants to merge 2 commits into from

Conversation

TheAbsolutionism
Copy link

@TheAbsolutionism TheAbsolutionism commented Nov 9, 2024 •
edited
Loading

Description

This PR aims to change the exactOperationExists method within the Arithmetic class allowing skript-addons to ensure an operation does or does not already exist if registered by another addon.

Target Minecraft Versions: any
Requirements: none
Related Issues: #7206

@Moderocky
Copy link
Member

Please put a little more effort into writing your PR name/description: these are auto-exported in change history & difference logs and it won't be very clear when searching through the contribution history what "thingy" is or what this is "fixing"

@UnderscoreTud
Copy link
Member

Make exactDifferenceExists public as well

@TheAbsolutionism TheAbsolutionism changed the title Arithmetic Thingy Arithmetic Methods Update Nov 9, 2024
@TheAbsolutionism TheAbsolutionism changed the title Arithmetic Methods Update Arithmetic Private Methods Changed to Public Nov 9, 2024
Pikachu920
Pikachu920 requested changes Nov 9, 2024
View reviewed changes
Copy link
Member

@Pikachu920 Pikachu920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think making these public is not the right way for addon devs to accomplish this. if registration fails, a skriptapiexception is thrown and can be caught by the caller

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Nov 16, 2024
@sovdeeth
Copy link
Member

I think making these public is not the right way for addon devs to accomplish this. if registration fails, a skriptapiexception is thrown and can be caught by the caller

I think it'd be nicer to know whether it will works or not prior to doing all the work to make the arithmetic. Do you foresee a reason that exposing these methods would be negative?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pikachu920 Pikachu920 Pikachu920 requested changes

@Asleeepp Asleeepp Asleeepp approved these changes

@UnderscoreTud UnderscoreTud UnderscoreTud approved these changes

@Fusezion Fusezion Fusezion approved these changes

@Romitou Romitou Romitou approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@TheAbsolutionism @Moderocky @UnderscoreTud @sovdeeth @Pikachu920 @Romitou @Fusezion @Asleeepp